CA-366014 UPD-825 pass dm qemu to UEFI qemu, too #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport from xe-api.git: * c12905cfbd5ca7d502bb05468d98122457cf9aff * 5f33eb2fd251e7183098f4ef96233f28b6198974 * ec2f3c0e0ae794c2ca3e4b966f8e7d4a90e33760 emu-manager needs '-dm qemu' flag for migration to work correctly with upstream QEMU. Otherwise emu-manager doesn't send xen-set-global-dirty-log and some guest drivers may crash upon resume (e.g. the mouse). Treat Qemu_upstream_uefi as upstream too and pass the flag. Commit 0e8624a introduced '-dm qemu' but the UEFI version of the qemu profile didn't exist yet at the time. Later commit 971d788 introduced the UEFI qemu profile, and the build still worked due to the wildcard, so the missing flag went unnoticed until now. Replace the wildcard with an explicit list of when '-dm qemu' shouldn't be added, so the next time we introduce a new qemu profile we get a build failure and must decide which behaviour would be correct. Signed-off-by: Edwin Török <edvin.torok@citrix.com> Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
robhoes
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from xe-api.git:
emu-manager needs '-dm qemu' flag for migration to work correctly with
upstream QEMU. Otherwise emu-manager doesn't send
xen-set-global-dirty-log and some guest drivers may crash upon resume
(e.g. the mouse).
Treat Qemu_upstream_uefi as upstream too and pass the flag.
Commit 0e8624a introduced '-dm qemu'
but the UEFI version of the qemu profile didn't exist yet at the time.
Later commit 971d788 introduced the
UEFI qemu profile, and the build still worked due to the wildcard,
so the missing flag went unnoticed until now.
Replace the wildcard with an explicit list of when '-dm qemu' shouldn't
be added, so the next time we introduce a new qemu profile we get a
build failure and must decide which behaviour would be correct.
Signed-off-by: Edwin Török edvin.torok@citrix.com
Signed-off-by: Christian Lindig christian.lindig@citrix.com