CP-38343: backport xenopsd memory usage tracking to Havana #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forget_client leaks a thread, it doesn't actually tell it to finish or join it, just sets a global variable to None. We do not actually daemonize anymore (we use systemd), so wrap the forget_client call in an `if !daemon'. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
|
#772 the trunk version is here |
lindig
approved these changes
Oct 22, 2021
lindig
approved these changes
Dec 6, 2021
VM.import_metadata_async creates a task and ignores it. This causes the tasks to accumulate in the tasks and updates list, causing high CPU and memory usage. Set a flag on these tasks to automatically destroy them when they finish (i.e. complete or fail). If the task is already finished at the time we set the flag (there could be a race), then immediately destroy it. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
… instead of Uutf.{encode,decoder}
Uutf.encoder allocates a 64k buffer internally (in addition to our 1k buffer).
Use Uutf.Buffer to write utf8 chars directly into our buffer instead.
Also size the buffer based on initial string size (it can grow if needed).
This should reduce allocation rate.
Thanks to a hint from https://discuss.ocaml.org/t/decoding-many-unicode-strings-with-uutf/8910/2
Also avoid allocations if string is all utf8
This could be further optimized to stop on first invalid utf8 char and
do the recode on the rest.
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
edwintorok
force-pushed
the
private/edvint/xsi-xenopsd
branch
from
2128e9d to
792fdd7
Compare
|
Dropped the memory logging and RRD changes, keeping just the 2 leak fixes (the thread, and memory leak), and the utf8 optimization. |
lindig
approved these changes
Dec 6, 2021
robhoes
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To debug a potential memory leak, not intended for merging yet.