CA-357785: squeezed logs to xensource.log #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
changed the title
robhoes
reviewed
Sep 30, 2021
squeezed/src/squeezed.ml
Outdated
|
|
||
| let _ = | ||
| Debug.set_facility Syslog.Local5 ; | ||
| Debug.set_level Syslog.Info ; |
There was a problem hiding this comment.
I think that almost everything is logged as debug, so this may be a bit harsh. The facility is the main one to get things out of daemon.log. But what about the logging to stdout?
There was a problem hiding this comment.
I've removed the custom logging facilities, it still could be better by changing the "verbose" variables passed around.
robhoes
reviewed
Oct 1, 2021
psafont
changed the title
robhoes
approved these changes
Oct 1, 2021
This solves the issue that the output infrastructure is shared between the testing code and the tested code Also add squeezed tests to its package Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Xcp_service used to be able to configure where squeezed logged to but it doesn't seem to work anymore. Set the facility to local5 which syslog directs to xensource.log Also replaces the custom logging facility that logged to stdout by default and fixes the name of the module in the logs Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
lindig
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcp_service used to be able to configure where squeezed logged to but it doesn't seem to work anymore.
Set the facility to local5 which logs to xensource.log
I've taken the liberty to change the tests to alcotest to avoid using the same (flawed) logging facilities for the testing code and the tested code.