CA-334758 - Allow plug of vbds for sds vms #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
reviewed
May 7, 2021
robhoes
reviewed
May 7, 2021
|
Marking as draft since it's a work in progress |
Cache Dom0's UUID in Xenops_server.dom0_uuid: it doesn't change and needs to be known on each VBD plug operation. When storage driver domains are used we need to plug VBDs into Dom0, because the backend runs in another domain and we don't have direct access to the VDIs. Xenopsd only considers VMs that it manages as valid targets for VBD plug, so Dom0 needs to be added to that condition explicitly. The 'is managed by me' condition is not changed, because we only want to allow this for VBD operations, and not for other operations. Signed-off-by: bensi <ben.sims@citrix.com> Signed-off-by: Edwin Török <edvin.torok@citrix.com>
edwintorok
force-pushed
the
private/bensi/CA-334758
branch
from
87834fb to
616f9bf
Compare
robhoes
approved these changes
Jul 23, 2021
|
It works: |
|
It works: |
psafont
approved these changes
Jul 26, 2021
lindig
reviewed
Jul 26, 2021
|
I think the xenopsd simulator won't have a Dom0. I can try to add a unit test for this and modify the simulator in a separate PR (it'll also need changes in XAPI, which is where the simulator is used). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another piece of logic that was blocking vbds being plugged into dom0
I need to run a final BST to ensure no regressions, hence the no merge flag.