s/xe-syslog-reconfigure: Keep disclaimer in remote.conf #6774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behaviour is same, except that the file will remain (with empty rules) even if the forwarding log has been disabled (and then prevent the disclaimer loss). Wording slightly modified to reduce the risk of concurrent management of this file, if the file is still edited by other mean, it will be done knowingly (that x-s-r may override any change soon or later). For the record remote.conf was introduced in: 468eb75 . I am assuming that the presence of file is not checked elsewhere that in xen-api (currently only s/x-s-r is referencing this file). Signed-off-by: Philippe Coval <philippe.coval@vates.tech>
lindig
reviewed
Nov 28, 2025
Contributor
lindig
left a comment
lindig
left a comment
There was a problem hiding this comment.
Is the main change here not the updated logic? Now remote.conf is never removed because the else branch is removed.
Author
yes file will never be removed, this is the motivation of this change It will be just empty (with header disclaimer) OR filed with rule if remote logging is enabled Keeping the file, can also give hint to user and prevent him to create an other rule elsewhere. |
lindig
approved these changes
Nov 28, 2025
psafont
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour is same, except that the file will remain (with empty rules) even if the forwarding log has been disabled (and then prevent the disclaimer loss).
Wording slightly modified to reduce the risk of concurrent management of this file, if the file is still edited by other mean, it will be done knowingly (that x-s-r may override any change soon or later).
For the record remote.conf was introduced in:
468eb75 .
I am assuming that the presence of file is not checked elsewhere that in xen-api (currently only s/x-s-r is referencing this file).