xenopsd/xc: upstream more NUMA changes #6554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9e6fb15 Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
On xen versions that don't support this call yet, xenctrlext will simply fail and continue to behave like before. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This interface is not yet available in xen, so fail before doing the hypercall. This patch is meant to be reverted on system that provide the new interface for easily test it. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
lindig
approved these changes
Jun 25, 2025
| | [Node node] -> | ||
| Some (Xenctrlext.NumaNode.from node, node) | ||
| | [] | _ :: _ :: _ -> | ||
| D.debug |
There was a problem hiding this comment.
Would suggest to elevate this to info
mg12
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits allow to minimize the differences between the versions that use a xen with the NUMA-enabled claim_pages, and the ones that are not.
Now it's a single patch with 4 lines of code: