Tweaks to cpu metrics #6530
Merged
Tweaks to cpu metrics #6530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BengangY
approved these changes
Jun 13, 2025
|
Please explain in the commit why the new name is better. for example: the name name makes it clear there's at least one cpu in the runnable stable, previously this was not clear |
The renaming is done to resolve one problem with rrd2csv: rrd2csv
selected both RRD1("runnable") and RRD2("runnable_vcpus") when the RRD1
name is used:
> rrd2csv AVERAGE:vm:<vm-uuid>:runnable
> timestamp, AVERAGE:vm:<vm-uuid>:runnable, AVERAGE:vm:<vm-uuid>:runnable_vcpus
This is because "runnable" is a prefix of "runnable_vcpus".
After the renaming, with rrd2csv:
* can select only RRD1 if we use:
rrd2csv AVERAGE:vm:<vm-uuid>:runnable_any
* can select only RRD2 if we use:
rrd2csv AVERAGE:vm:<vm-uuid>:runnable_vcpus
* can select both RRD1 and RRD2 if we use:
rrd2csv AVERAGE:vm:<vm-uuid>:runnable
And the renaming also makes it clearer as the 'runnable' metric is % of
time that at least one vCPU of the domain is in the runnable state.
Signed-off-by: Gang Ji <gang.ji@cloud.com>
Follow the fix here: xapi-project#6493 Signed-off-by: Gang Ji <gang.ji@cloud.com>
gangj
force-pushed
the
private/gangj/rrd1-fixup
branch
from
a860b90 to
a9a0c18
Compare
psafont
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.