CP-47063: Tracing instrumentation around message-switch send #6503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBuica
force-pushed
the
private/dbuica/CP-46859-dev
branch
2 times, most recently
from
9f13ae1 to
dad01ee
Compare
GabrielBuica
changed the title
mg12
reviewed
Jun 4, 2025
mg12
reviewed
Jun 4, 2025
mg12
reviewed
Jun 4, 2025
|
Is it difficult to instrument other calls, or is it because it generates too much data? |
@psafont I am planning to instrument more in subsequent PRs. I think the most difficult part would be passing the a debug_info type in the call params which contains the trace_context and the dbg. Now, we are passing a string and we need to process that string everytime... |
GabrielBuica
force-pushed
the
private/dbuica/CP-46859-dev
branch
from
dad01ee to
fbe33d6
Compare
psafont
reviewed
Jun 5, 2025
GabrielBuica
force-pushed
the
private/dbuica/CP-46859-dev
branch
from
ad215a8 to
895636b
Compare
Instruments: - `VM.add`, - `VM.stat`, - `VM.exists`, - `VM.list`. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
Instruments `switch_rpc` according to OpenTelemetry standard on instrumenting rpc calls. - `server.address` is the name of the message queue. Intruments sending the message on a queue according to OpenTelemetry standard on instrumenting messaging. - `destination` is the name of the message queue. `Tracing.with_tracing` now accepts an optional argument to set the Span Kind. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
GabrielBuica
force-pushed
the
private/dbuica/CP-46859-dev
branch
from
895636b to
5138375
Compare
psafont
approved these changes
Jun 12, 2025
edwintorok
approved these changes
Jun 12, 2025
Merged
via the queue into
xapi-project:master
with commit Jun 12, 2025
502fc45
23 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrument xenops vm non-atomic functions.
Instruments:
VM.add,VM.stat,VM.exists,VM.list.Instruments
switch_rpcaccording to OpenTelemetry standard oninstrumenting rpc calls.
server.addressis the name of the message queue.Intruments sending the message on a queue according to OpenTelemetry
standard on instrumenting messaging.
destinationis the name of the message queue.Tracing.with_tracingnow accepts an optional argument to set the SpanKind.