Reapply "CA-403867: Block pool join if IP not configured on cluster n… #6441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangj
force-pushed
the
private/gangj/CP-53800
branch
from
ff20c17 to
4dda4cb
Compare
|
We can re-apply the fix as the blocking/required update in XenRT has been merged. |
minglumlu
reviewed
Apr 27, 2025
ocaml/xapi/xapi_pool.ml
Outdated
| ~self:(Helpers.get_localhost ~__context) | ||
| |> List.filter (fun p -> | ||
| List.exists | ||
| (fun d -> Db.PIF.get_device ~__context ~self:p = d) |
There was a problem hiding this comment.
I would suggest using the PIF.network -> Network.bridge to determine if they are corresponding devices.
The device names here will not be renamed as eth with the network device ordering feature. In other words, the devices connect to the same network may have different names.
Vincent-lau
reviewed
Apr 29, 2025
ocaml/xapi/xapi_pool.ml
Outdated
| | pif when pif = Ref.null -> | ||
| () | ||
| | pif -> ( | ||
| match Client.PIF.get_VLAN ~rpc ~session_id ~self:pif with |
There was a problem hiding this comment.
There is quite a bit of nesting here. Can we take put some of these into a inner function to reduce this?
minglumlu
approved these changes
May 7, 2025
lindig
approved these changes
May 7, 2025
Vincent-lau
approved these changes
May 7, 2025
Refix with some review comments addressed. To join a host into a pool with cluster enabled, the host must have one and only one IP configured on the joining cluster network. If not, after the host joinied the pool, GFS2 SR cannot be plugged on the joined host because an IP is required in the cluster network. Pool join in this scenario has been blocked in XenCenter, here we will block it inside xapi. Signed-off-by: Gang Ji <gang.ji@cloud.com>
gangj
force-pushed
the
private/gangj/CP-53800
branch
from
02e17f3 to
caaad26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etwork"
This reverts commit 8ce5a53.