XSI-1821: Add pre-condition for host.emergency_reenable_tls_verification #6322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
approved these changes
Feb 26, 2025
robhoes
reviewed
Feb 26, 2025
psafont
requested changes
Feb 26, 2025
|
I think one protection that can be worth doing is to fail when the normal tls_enable can be done. That is, the database is available and certificate checking is off for the pool. The error should direct the user to use the normal call |
|
I agree with @psafont 's last comment: the host re-enable call should only be used if the pool has verification enabled. |
gangj
force-pushed
the
private/gangj/XSI-1821
branch
from
75dec32 to
03c7c0a
Compare
gangj
changed the title
gangj
force-pushed
the
private/gangj/XSI-1821
branch
from
03c7c0a to
4669a5e
Compare
gangj
force-pushed
the
private/gangj/XSI-1821
branch
from
4669a5e to
149d437
Compare
psafont
reviewed
Feb 27, 2025
host.emergency_reenable_tls_verification can only be used after TLS verification is enabled in pool, raise an error if otherwise. Signed-off-by: Gang Ji <gang.ji@cloud.com>
gangj
force-pushed
the
private/gangj/XSI-1821
branch
from
5ddb4cd to
14da91a
Compare
psafont
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
host.emergency_reenable_tls_verification can only be used after TLS
verification is enabled in pool, raise an error if otherwise.