Design proposal to support import/export of Qcow2 VDI #6318
Conversation
At XCP-ng, we are working on overcoming the 2TiB limitation for VM disks while preserving essential features. However, we currently cannot export a VDI to a Qcow2 file, nor import one. The purpose of this design proposal is to outline a solution for implementing VDI import/export in Qcow2 format. Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech>
Agree. It is more to initiate the discussion and have some feedback but yes I need to improve it. Are you thinking about the part about qcow-tool? Because for this part I'm not sure about what is needed. I see that command |
There was a problem hiding this comment.
This work seems lmited scope and reasonable, although a bit light in the details surrounding the work that needs to be done.
I think it's worth explaining one aspect in particular:
What does adding support for Qcow 2 mean for the handler? That is, how does the detection of format work and how it should be modified?
Ok sure. I will add details about this particular aspect and also in general. |
gthvn1
force-pushed
the
feature/add-qcow-tool-for-vdi-import-export
branch
from
0a8024c to
d137934
Compare
| - Since the format is checked in the handler, we need to add support for `Qcow2`, | ||
| as currently only `Raw`, `Tar`, and `Vhd` are supported. | ||
| - This requires adding a new type in the `Importexport.Format` module and a new | ||
| content type: `"application/qcow2"`. |
There was a problem hiding this comment.
There's no official type for qcow2, so I recommend against using a mime type that's not prepended with x-. Following qcow's mime type, I recommend application/x-qemu-disk-2, removing '-2' might also be acceptable.
There was a problem hiding this comment.
I will update that thanks. I'm also trying to have a better understanding about how vhd-tool serve and vhd-tool stream are working because it is not clear yet what is the Unix file descriptor that is used and how it works within the XAPI. So I'm currently having a closer look to the code and I will update the section.
Thanks for the comment about mimetype 👍
d5f67ad
|
Probably should have squashed the fixups before merging? |
|
not sure why github allowed it |
4 participants
At XCP-ng, we are working on overcoming the 2TiB limitation for VM disks while preserving essential features.
However, we currently cannot export a VDI to a Qcow2 file, nor import one. The purpose of this design proposal is to outline a solution for implementing VDI import/export in Qcow2 format.