CP-53161: Baggage threaded through smapi and back into xapi
#6278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBuica
force-pushed
the
private/dbuica/CP-53161
branch
from
3cc819e to
4558f24
Compare
These changes append the `baggage` of the `trace_context` to the list of environment variables that are about to be submitted to SM scripts by `forkexec`. This should improve the propagation of `trace_context` along traces that use multiple components. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
This links requests back into `xapi` from `smapi` to the xapi request that called the SM scripts in the first place. When `smapi` was experimental there would be no traceparent header passed in the request from `smapi` to `xapi`. Now, when `smapi` is experimental and the tracing is enabled for xapi, the traceparent passed to `smapi` is passed back to `xapi` for each request. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
GabrielBuica
force-pushed
the
private/dbuica/CP-53161
branch
from
4558f24 to
f4465eb
Compare
psafont
approved these changes
Feb 27, 2025
lindig
reviewed
Feb 27, 2025
edwintorok
approved these changes
Mar 3, 2025
xs-aidan
reviewed
Mar 3, 2025
When a the baggage is passed as an environment variable, it is now added to the resource attributes inside of `observer.py`. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
Just as the traceparent is passed back as an additional header, now the baggage is passed as well in the http request coming from `smapi` back into `xapi`. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
GabrielBuica
force-pushed
the
private/dbuica/CP-53161
branch
from
29faa32 to
87a4a5a
Compare
snwoods
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It continues the path of threading the
trace_contextacross different components. Specifically, fromxapitosmapiand back toxapi.Additional improvement: the tracecontext is passed even when
smapicomponent is experimental and it does not create spans. Therefore, it is not creating orphaned spans from http requests made to xapi.BVT+BST: 213297