Remove dangling use of python-future from rrdd.py #6247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Syms <mark.syms@cloud.com>
MarkSymsCtx
requested review from
Vincent-lau,
andyhhp,
bernhardkaindl,
edwintorok,
lindig,
psafont and
robhoes
edwintorok
approved these changes
Jan 22, 2025
andyhhp
reviewed
Jan 22, 2025
| from __future__ import print_function | ||
|
|
||
| from future import standard_library | ||
| standard_library.install_aliases() |
There was a problem hiding this comment.
If you drop this, you need httplib and xmlrpclib for Py2.7 compatibility.
Those are the only ones, so I'd suggest this form:
try:
import http.client
except ImportError:
import httplib
There was a problem hiding this comment.
we have dropped python2.7 support on xapi master.
Yangtze support is on another release branch.
There was a problem hiding this comment.
This isn't packaged for Python 2 anymore
Except for requiring python3-future as an RPM requires. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.