maintenance: add interface files for vhd-tool #6052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This detects some unused bindings and a mutable field. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Also change the interface and explain the meaning behind the values. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
The datastructure is mean to serialize the offset and length of a piece of disk, not its data. This also frontloads the possible conversion failure to the creation of the datastructure. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
contificate
approved these changes
Oct 11, 2024
lindig
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This detects some unused bindings and a mutable field. Chunked got also documented and changed the interface to make it more understandable to use.