CP-51714: Remove noisy xenopsd debug logs #6039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snwoods
commented
Oct 3, 2024
| try | ||
| if Events_from_xenopsd.are_suppressed (fst id) then | ||
| debug "xenopsd event: ignoring event for VM (VM %s migrating away)" | ||
| debug "xenopsd event: ignoring event for VBD (VM %s migrating away)" |
There was a problem hiding this comment.
I presume this was originally a copy-paste error, VM instead of VBD? The same with s/VM/VUSB migrating away later
psafont
approved these changes
Oct 3, 2024
lindig
approved these changes
Oct 4, 2024
| let wait_shutdown task vm _reason timeout = | ||
| let is_vm_event = function | ||
| | Dynamic.Vm id when id = vm.Vm.id -> | ||
| debug "EVENT on our VM: %s" id ; |
There was a problem hiding this comment.
I think this should stay: we have an event that we are looking for
Signed-off-by: Steven Woods <steven.woods@citrix.com>
snwoods
force-pushed
the
private/stevenwo/CP-51714
branch
from
19caae9 to
e3675a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably overzealous, so please let me know if some of these logs are still helpful. I have kept the "migrating away" logs as Christian said these are rare.