Skip to content

Conversation

@psafont
Copy link
Member

@psafont psafont commented Oct 2, 2024

This is needed to generate the vif script and make it installable

@robhoes
Copy link
Member

robhoes commented Oct 2, 2024

I see this comment on top of the file that is changed here:

# This file is generated by dune, edit dune-project instead

Do you need to add a dune-project change?

@psafont
Copy link
Member Author

psafont commented Oct 2, 2024

Do you need to add a dune-project change?

No, dune doesn't have a way to override the build step using dune-project. Instead it allows to have a .opam.template file that is copy-pasted at the end of the .opam file.

I added manually the opam.template file, and dune changed the .opam file after running make

This is needed to generate the vif script and make it installable

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
@psafont
Copy link
Member Author

psafont commented Oct 2, 2024

Added more dependencies found while testing xapi-project/xs-opam#703

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
@psafont psafont enabled auto-merge October 2, 2024 13:40
@psafont psafont added this pull request to the merge queue Oct 2, 2024
Merged via the queue into xapi-project:master with commit ec0151b Oct 2, 2024
15 checks passed
@psafont psafont deleted the instafix branch October 2, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants