fix(xapi)): cannot compare functional values #6034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhoes
approved these changes
Oct 2, 2024
last-genius
approved these changes
Oct 2, 2024
We had a bug that would not fail any unit tests, but XAPI would fail to start
This reproduces the error now:
```
[invalid] compare: functional value
Raised by primitive operation at Xapi_globs.other_options.(fun) in file "ocaml/xapi/xapi_globs.ml", line 1622, characters 17-59
Called from Xcp_service.Config_file.dump.(fun) in file "ocaml/xapi-idl/lib/xcp_service.ml", line 145, characters 34-46
Called from Stdlib__List.iter in file "list.ml", line 110, characters 12-15
Called from Xcp_service.configure_common in file "ocaml/xapi-idl/lib/xcp_service.ml", line 432, characters 2-30
Called from Xcp_service.configure in file "ocaml/xapi-idl/lib/xcp_service.ml", line 461, characters 4-259
Called from Alcotest_engine__Core.Make.protect_test.(fun) in file "src/alcotest-engine/core.ml", line 181, characters 17-23
Called from Alcotest_engine__Monad.Identity.catch in file "src/alcotest-engine/monad.ml", line 24, characters 31-35
```
Also print the Failure message in Xcp_service.configure, otherwise it'd exit 1 without saying why if you supply invalid cmdline arguments.
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Fixes: 6635a00 ("CP-49136: Introduce PRNG for generating non-secret UUIDs") Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/startup2
branch
from
8b6c891 to
a3ab228
Compare
psafont
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 6635a00 ("CP-49136: Introduce PRNG for generating non-secret UUIDs")