fix(WLS): disable non-root unit test #5973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fails when running kojienv from WSL2, but works when running kojienv from an actual Linux. In a WSL2 kojienv /dev/loop0 is world writable (even though the user is not root), whereas in a real kojienv /dev/loop0 is not wordl writable. This test was here just to test my assumptions that indeed non-root cannot create block devices, assumptions which are not true in WSL2, so remove this test. In Dom0 we run as root always, so this has no effect on the product. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
MarkSymsCtx
approved these changes
Sep 4, 2024
|
typo in the commit title |
last-genius
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails when running kojienv from WSL2, but works when running kojienv from an actual Linux. In a WSL2 kojienv /dev/loop0 is world writable (even though the user is not root), whereas in a real kojienv /dev/loop0 is not world writable.
This test was here just to test my assumptions that indeed non-root cannot create block devices, assumptions which are not true in WSL2, so remove this test.
In Dom0 we run as root always, so this has no effect on the product.