CA-393507: Default cluster_stack value #5674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `@default` attribute to the `cluster_stack` field in the cluster config. This field was introduced in #c1bd0e31a but causes RPU to fail since it is not optional, and while xapi-clusterd was unmarshalling an old db (which contains cluster config), it cannot find this field, and throws an exception. Adding `@default` can make the rpc library to fill this field in when it is missing, solving the above problem. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
robhoes
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
@defaultattribute to thecluster_stackfield in the cluster config. This field was introduced in #c1bd0e31a but causes RPU to fail since it is not optional, and while xapi-clusterd was unmarshalling an old db (which contains cluster config), it cannot find this field, and throws an exception.Adding
@defaultcan make the rpc library to fill this field in when it is missing, solving the above problem.Manul test looks ok, waiting for xrt tests.