Go SDK: Misc fixes for on-going component tests #5661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minglumlu
force-pushed
the
private/mingl/add_json_tag
branch
from
58136ec to
510acd8
Compare
This aims to allow a Go SDK client to unmarshal JSON to Go structs with the function in Go json pacakge instead of using Go SDK. The unmarshalling in Go SDK contains two steps: JSON -> map -> struct. This is because some special cases need to be handled explicitly. But for sake of safety, this unmarshalling is not exposed to clients. Signed-off-by: Ming Lu <ming.lu@cloud.com>
The date time in Go requires a date time with timezone info. But XAPI may return a UNIX timestamp to clients. This commit blindly adds a UTC timezone for UNIX timestamps returned from XAPI server. Signed-off-by: Ming Lu <ming.lu@cloud.com>
Some special values of float standing in JSON are handled specifically. This commit allows the special values contain spaces. Signed-off-by: Ming Lu <ming.lu@cloud.com>
This check complains the struct json tag naming style. It expects the Caml style, but Go SDK has to use Snake. Signed-off-by: Ming Lu <ming.lu@cloud.com>
minglumlu
force-pushed
the
private/mingl/add_json_tag
branch
from
510acd8 to
589ec0a
Compare
xueqingz
approved these changes
May 31, 2024
xihuan-citrix
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP-49707: Go SDK: Add JSON tag for structs
This aims to allow a Go SDK client to unmarshal JSON to Go structs with
the function in Go json pacakge instead of using Go SDK.
The unmarshalling in Go SDK contains two steps: JSON -> map -> struct.
This is because some special cases need to be handled explicitly.
But for sake of safety, this unmarshalling is not exposed to clients.
CP-49349: Go SDK: Append UTC timezone to unix timestamp
The date time in Go requires a date time with timezone info. But XAPI
may return a UNIX timestamp to clients.
This commit blindly adds a UTC timezone for UNIX timestamps returned
from XAPI server.
CP-49349: Go SDK: Allow spaces in special value of float type
Some special values of float standing in JSON are handled specifically.
This commit allows the special values contain spaces.