Remove CVM and relevant test cases #5655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CVM had been supported but not since long time ago. This commit is to clean up the remanent code and test cases. Signed-off-by: Ming Lu <ming.lu@cloud.com>
minglumlu
force-pushed
the
private/mingl/remove-cvm
branch
from
3a80f2a to
5036409
Compare
gangj
reviewed
May 29, 2024
| Xapi_xenops.start ~__context ~self:vm5 false false ; | ||
| Xapi_xenops.start ~__context ~self:vm6 false false ; | ||
| Xapi_xenops.start ~__context ~self:vm7 false false ; | ||
| (* vm6 is a ntnx CVM *) |
There was a problem hiding this comment.
Since we are removing CVM related logic as CVM is not supported now, is the test for vm6 still needed?
psafont
reviewed
May 29, 2024
ocaml/tests/test_xapi_xenops.ml
Outdated
| Xapi_xenops.start ~__context ~self:vm6 false false ; | ||
| Xapi_xenops.start ~__context ~self:vm7 false false ; | ||
| (* vm6 is a ntnx CVM *) | ||
| Db.VM.set_is_control_domain ~__context ~self:vm6 ~value:true ; |
There was a problem hiding this comment.
Shouldn't this line be removed as well?
There was a problem hiding this comment.
I think the comment is not correct. The vm6 is actually not a CVM. Its name doesn't end with "-CVM".
Signed-off-by: Ming Lu <ming.lu@cloud.com>
Signed-off-by: Ming Lu <ming.lu@cloud.com>
Signed-off-by: Ming Lu <ming.lu@cloud.com>
gangj
approved these changes
May 29, 2024
psafont
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVM had been supported but not since long time ago.
This commit is to clean up the remanent code and test cases.