tests: Allow the alcotest_suite to run #5604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Not sure how to best detect this kind of bug in the quality gate.
If there are multiple modules with side-effects and some of them exit the program then whether some testsuites run or not depends on the linking order, which might depend on the order in which files got layed out on the filesystem (which depends on the kind of FS you have, some use a hashtable...)
We want only 1 Alcotest.run (or equivalent call, there are 2 more variants I think) in a single program.
But tests/ has multiple different programs too.
gangj
approved these changes
Apr 30, 2024
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.