CA-392163 clear scheduled assignments on startup #5602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear all (stale) scheduled assignments for: VM, PCI, VGPU objects on startup. We were missing the latter two. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
minglumlu
reviewed
Apr 30, 2024
| Db.VM.set_scheduled_to_be_resident_on ~__context ~self ~value:Ref.null | ||
| ) | ||
| (Db.VM.get_all ~__context) | ||
| (* Clear all assignments that are only scheduled *) |
There was a problem hiding this comment.
I understand these scheduled_* fields are used only by the coordinator to remember something within XAPI calls. So it will be safe to clean all of these fields when the xapi on coordinator is in starting up, as at the moment no any xapi calls are in progress.
minglumlu
approved these changes
Apr 30, 2024
Vincent-lau
approved these changes
Apr 30, 2024
|
I will think about that for another PR because this will prevent stale PCI slots that are cleaned up in the code here. |
robhoes
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear all (stale) scheduled assignments for: VM, PCI, VGPU objects on startup. We were missing the latter two.