Skip to content

Conversation

@jonathanknowles
Copy link
Contributor

A small clean-up of Xapi_pif.{ml,mli}:

  • Removes a few functions from the public interface that don't need to be there.
  • Replaces redundant list processing functions with their standard library equivalents.
  • Corrects the broken-ish indendation.

$ git checkout master
  Switched to branch 'master'
$ camlp4 -parser o -printer o -no_comments ocaml/xapi/xapi_pif.ml | md5sum
  7c232fb2c8e865b49b38d1b07e38c33b  -
$ git checkout CP-2371
  Switched to branch 'CP-2371'
$ camlp4 -parser o -printer o -no_comments ocaml/xapi/xapi_pif.ml | md5sum
  7c232fb2c8e865b49b38d1b07e38c33b  -

Signed-off-by: Xen Git User <xen-git@citrix.com>
…_internal" from the public interface of Xapi_pif.

Signed-off-by: Jonathan Knowles <jonathan.knowles@eu.citrix.com>
…ndard library function.

Signed-off-by: Jonathan Knowles <jonathan.knowles@eu.citrix.com>
Signed-off-by: Jonathan Knowles <jonathan.knowles@eu.citrix.com>
@robhoes
Copy link
Member

robhoes commented Mar 18, 2011

My patches for PR-1006 are scheduled to go in on Monday, and touch the same code. Could we please not merge anything like this before PR-1006 is in?

@xen-git
Copy link
Contributor

xen-git commented Mar 18, 2011

Build succeeded. Can merge jonathanknowles/xen-api@1e852b0 with 2f63e3a.

@jonathanknowles
Copy link
Contributor Author

As these patches touch the same piece of code as Rob's patches, and because Rob's patches are scheduled to go in on Monday, I've retracted this pull request.

Instead, I'll rebase my changes on top of Rob's changes, and make another pull request in future.

sharady pushed a commit to sharady/xen-api that referenced this pull request May 20, 2015
koushikcgit pushed a commit to koushikcgit/xen-api that referenced this pull request Aug 7, 2015
…-part

Blkfront will always use .../vbd/... path
johnelse pushed a commit to johnelse/xen-api that referenced this pull request Dec 9, 2015
kc284 pushed a commit to kc284/xen-api that referenced this pull request Mar 11, 2021
robhoes pushed a commit to robhoes/xen-api that referenced this pull request Jul 6, 2021
robhoes pushed a commit that referenced this pull request Sep 14, 2021
CA-182722: Update RRDs only once per SR
robhoes pushed a commit that referenced this pull request Sep 14, 2021
Replaced jbuild files with dune.
robhoes pushed a commit to robhoes/xen-api that referenced this pull request Sep 21, 2021
…apath

[Merge qemu-datapath/ Catch EAGAIN from sendfile and retry
psafont pushed a commit to psafont/xen-api that referenced this pull request Oct 19, 2021
CA-113824: Refactor code for getting devices
robhoes pushed a commit to robhoes/xen-api that referenced this pull request Nov 23, 2021
[opam/next] Update to support core/async >= v0.9.0
robhoes pushed a commit to robhoes/xen-api that referenced this pull request Nov 23, 2021
edwintorok pushed a commit to edwintorok/xen-api that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants