Skip to content

Conversation

@bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Jan 23, 2024

@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch from 403f3f6 to 8965cca Compare January 23, 2024 07:45
@codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@2a991fe). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5384   +/-   ##
=========================================
  Coverage          ?   44.70%           
=========================================
  Files             ?       18           
  Lines             ?     2982           
  Branches          ?        0           
=========================================
  Hits              ?     1333           
  Misses            ?     1649           
  Partials          ?        0           
Flag Coverage Δ
python2.7 50.88% <0.00%> (?)
python3.11 49.31% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch from 8965cca to 8c3877f Compare January 23, 2024 15:59
@xapi-project xapi-project deleted a comment from github-actions bot Jan 23, 2024
@xapi-project xapi-project deleted a comment from github-actions bot Jan 23, 2024
@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch 2 times, most recently from 0cd48eb to ae09972 Compare January 23, 2024 16:43
@psafont
Copy link
Member

psafont commented Jan 23, 2024

pytype is spitting out quite a few errors, but the check remains green. IMHO it should be made a fatal error. not sure how to separate it from the other checks in pre-commit

pytype_runner: File "/home/runner/work/xen-api/xen-api/scripts/test_usb_scan.py", line 139, in test_usb_exit: Function TestUsbScan.assertIn was called with the wrong arguments [wrong-arg-types]
pytype_runner:          Expected: (self, member, container: Union[Container, Iterable], ...)
pytype_runner:   Actually passed: (self, member, container: int)
pytype_runner:   Attributes of protocol Container are not implemented on int: __contains__
pytype_runner: For more details, see https://google.github.io/pytype/errors.html#wrong-arg-types
pytype_runner: ninja: build stopped: subcommand failed.
Error: Function TestUsbScan.assertIn was called with the wrong arguments,          Expected: (self, member, container: Union[Container, Iterable], ...),   Actually passed: (self, member, container: int),   Attributes of protocol Container are not implemented on int: __contains__ https://google.github.io/pytype/errors.html#wrong-arg-types (you should find an entry in the pytype results with links below)

@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch 5 times, most recently from 181b64b to 1c08ff3 Compare January 23, 2024 22:46
if: ${{ matrix.python-version != '2.7' }}
run: |
pip install pandas pytype toml
./pytype_runner.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @psafont mentioned in #5365 (comment), packaging the file would make it more convenient for future use.

@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch 2 times, most recently from fc0be67 to 93bb8ed Compare January 24, 2024 02:20
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch from 93bb8ed to 973c184 Compare January 24, 2024 03:06
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch from 973c184 to fd5e102 Compare January 24, 2024 03:41
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch 2 times, most recently from ab8d4f7 to 317a1f9 Compare January 24, 2024 11:43
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch from 317a1f9 to d8f4599 Compare January 24, 2024 13:31
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@xapi-project xapi-project deleted a comment from github-actions bot Jan 24, 2024
@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch 2 times, most recently from 22bed76 to 73e078c Compare January 24, 2024 14:12
@github-actions
Copy link

github-actions bot commented Jan 24, 2024

pytype_reporter extracted 49 problem reports from pytype output.

You can check the results of the job here

@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch 4 times, most recently from 0a439a3 to 128e3b9 Compare January 24, 2024 16:18
@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch from 128e3b9 to 14d337c Compare January 25, 2024 10:40
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch from 14d337c to 99847ee Compare January 28, 2024 01:40
@bernhardkaindl bernhardkaindl force-pushed the private/bernhardk/python-add-code-coverage-reporting branch 3 times, most recently from 30635c6 to dae3d61 Compare January 28, 2024 03:29
Copy link
Member

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current issues in the porting procedure, I'd rather add the pytype_reporter rather than waiting for it to be published as a package

Copy link
Contributor

@edwintorok edwintorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly CI code, and the CI is all green. I haven't done an in-depth review for the CI code, but if we find any problems we can always easily fix it.
The actual change to product code is tiny, and that looks fine.

@bernhardkaindl bernhardkaindl merged commit ee472c7 into master Jan 30, 2024
@bernhardkaindl bernhardkaindl deleted the private/bernhardk/python-add-code-coverage-reporting branch May 25, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants