-
Couldn't load subscription status.
- Fork 293
CI/Python: Add reporting of code coverage from PyTest #5384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/Python: Add reporting of code coverage from PyTest #5384
Conversation
403f3f6 to
8965cca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5384 +/- ##
=========================================
Coverage ? 44.70%
=========================================
Files ? 18
Lines ? 2982
Branches ? 0
=========================================
Hits ? 1333
Misses ? 1649
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8965cca to
8c3877f
Compare
0cd48eb to
ae09972
Compare
|
pytype is spitting out quite a few errors, but the check remains green. IMHO it should be made a fatal error. not sure how to separate it from the other checks in pre-commit |
181b64b to
1c08ff3
Compare
.github/workflows/main.yml
Outdated
| if: ${{ matrix.python-version != '2.7' }} | ||
| run: | | ||
| pip install pandas pytype toml | ||
| ./pytype_runner.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @psafont mentioned in #5365 (comment), packaging the file would make it more convenient for future use.
fc0be67 to
93bb8ed
Compare
93bb8ed to
973c184
Compare
973c184 to
fd5e102
Compare
ab8d4f7 to
317a1f9
Compare
317a1f9 to
d8f4599
Compare
22bed76 to
73e078c
Compare
pytype_reporter extracted 49 problem reports from pytype output.You can check the results of the job here |
0a439a3 to
128e3b9
Compare
128e3b9 to
14d337c
Compare
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
14d337c to
99847ee
Compare
30635c6 to
dae3d61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current issues in the porting procedure, I'd rather add the pytype_reporter rather than waiting for it to be published as a package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly CI code, and the CI is all green. I haven't done an in-depth review for the CI code, but if we find any problems we can always easily fix it.
The actual change to product code is tiny, and that looks fine.
Uh oh!
There was an error while loading. Please reload this page.