Still Draft: Big Python3 megapatch, only as Demonstrator of findings from Static analysis #5372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Co-authored-by: Ashwinh <ashwin.h@cloud.com> Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
acefei
reviewed
Jan 22, 2024
| rev: v1.8.0 | ||
| hooks: | ||
| - id: mypy | ||
| files: ^scripts/(unit_tests|usb_reset.py) |
There was a problem hiding this comment.
Do we need to enable static checker for unit tests?
| @@ -0,0 +1,15 @@ | |||
| # manually derived from mypy'sy stubgen tool: | |||
There was a problem hiding this comment.
As Xapi's build requires xcp-python3-lib https://github.com/xenserver/python-libs/blob/master/xcp/logger.py, could we install it by pip in CI instead of duplicating it for mypy checking?
|
obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - For display only!
Extract of the Python3 changes from #5365, only for future reference - as where static analysis has found issues.
Removes 3 scripts that Lin Liu says are not packages and he says can be removed.
Only meant to as a display to see what changes pyright, pytype, and mypy found (with some clear issues, e.g. open2 was removed - and some str/bytes errors), and only below
scripts/(it's already a lot)