CP-46379: Set correct traceparent for storage_smapiv1*.ml functions
#5311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set proper parent relationship between spans in `storage_smapiv1.ml` and `storage_smapiv1_wrapper.ml`. Spans created from `storage_smapiv1_wrapper.ml` onwards were created under the same parent. This solves the issue by remaking `dbg` with the updated `traceparent`. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
robhoes
approved these changes
Dec 20, 2023
psafont
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set proper parent relationship between spans in
storage_smapiv1.mlandstorage_smapiv1_wrapper.ml.Spans created from
storage_smapiv1_wrapper.mlonwards were created under the same parent. This solves the issue by remakingdbgwith the updatedtraceparent.