Some fixup for external auth plugins #5306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25f3aca just disabled setup_logger, thus the logs are no longer saved, and available from status-report. Re-enable setup_logger, if /dev/log is not available, like in container during CI unittest, just skip redirect logs Signed-off-by: Lin Liu <lin.liu@citrix.com>
os.rename does not support cross device rename, in xs9, the /tmp is mounted with tmpfs seperately, got the invalid cross-device error. Update os.rename --> shutil.move for the fix Signed-off-by: Lin Liu <lin.liu@citrix.com>
|
psafont
reviewed
Dec 19, 2023
psafont
approved these changes
Dec 19, 2023
robhoes
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.