Add interface for flush spans and exit the export thread #5258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-lau
force-pushed
the
private/shul2/span-export
branch
from
cd8e1ea to
d8d94e4
Compare
robhoes
reviewed
Nov 23, 2023
Vincent-lau
force-pushed
the
private/shul2/span-export
branch
from
d8d94e4 to
7fae4b1
Compare
robhoes
approved these changes
Nov 23, 2023
mg12
approved these changes
Dec 15, 2023
Vincent-lau
force-pushed
the
private/shul2/span-export
branch
from
7fae4b1 to
068c55d
Compare
|
Looks like this needs a reformat now. |
Currently there is no way to force flush the spans in memory, this patch adds an interface to allow such flush. This is useful when, for example, clusterd is about to exit. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Vincent-lau
force-pushed
the
private/shul2/span-export
branch
from
068c55d to
ae881de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that daemons like clusterd can call it and flush the spans before they exit