CP-45977: Update scripts/extensions from python2 to python3 #5254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Nov 22, 2023
scripts/extensions/pool_update.apply
Outdated
| cmd = ['yum', 'clean', 'all', '--noplugins', '-c', yum_conf_file] | ||
| p = subprocess.Popen(cmd, shell=False, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, close_fds=True, env=yum_env) | ||
| output, _ = p.communicate() | ||
| output = output.decode('utf-8') |
There was a problem hiding this comment.
would it be better to call Popen with encoding='utf-8' so stdout is opened in text mode?
There was a problem hiding this comment.
Yes, you're right. Corrected!
There was a problem hiding this comment.
universal_newlines is often used to get the string output.
There was a problem hiding this comment.
Corrected and tested!
stephenchengCloud
force-pushed
the
private/stephenche/CP-45977
branch
3 times, most recently
from
bc12946 to
ec6e5c1
Compare
psafont
approved these changes
Nov 23, 2023
|
Minor comment: |
stephenchengCloud
force-pushed
the
private/stephenche/CP-45977
branch
from
ec6e5c1 to
9f24276
Compare
stephenchengCloud
changed the title
Done! |
liulinC
reviewed
Nov 27, 2023
| if os.path.isfile(update_precheck_file): | ||
| pp = subprocess.Popen(update_precheck_file, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, close_fds=True) | ||
| precheck_output, _ = pp.communicate() | ||
| precheck_output = precheck_output.decode("utf-8") |
There was a problem hiding this comment.
This one is missed for universal_newlines=True ?
There was a problem hiding this comment.
Corrected!
liulinC
approved these changes
Nov 27, 2023
Signed-off-by: Stephen Cheng <stephen.cheng@cloud.com>
stephenchengCloud
force-pushed
the
private/stephenche/CP-45977
branch
from
9f24276 to
6693647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.