CA-365486: repository-domain-name-allowlist could accept a full hostname #5233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minglumlu
approved these changes
Nov 8, 2023
psafont
reviewed
Nov 8, 2023
psafont
requested changes
Nov 14, 2023
psafont
reviewed
Nov 15, 2023
psafont
reviewed
Nov 17, 2023
psafont
approved these changes
Nov 20, 2023
|
Hi @duobei, Can you please squash the commits into one and fix the typo in commit message |
For the check of function `assert_url_is_valid`, repository-domain-name-allowlist doesn't work if you use the full FQDN for a server. The `assert_url_is_valid` only allows if the host ends with .<entry in repository-domain-name-allowlist>. Now it is extended to allow if the host matches the entry in the list too. Signed-off-by: Feiya Zhang <feiya.zhang@cloud.com>
duobei
force-pushed
the
private/fezhan/CA-365486
branch
from
7dfb371 to
18eded2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the check of function
assert_url_is_valid, repository-domain-name-allowlist doesn't work if you use the full FQDN for a server.The
assert_url_is_validonly allows if the host ends with .<entry inrepository-domain-name-allowlist>. Now it is extended to allow if the hosts matches the entry in the list too.