Revert "Cross-pool live migration: move CPU check to the target host" #5147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
approved these changes
Aug 11, 2023
|
See the fix in #5148 |
lindig
force-pushed
the
private/christianlin/CA-379112
branch
from
4561872 to
9f5fda9
Compare
robhoes
approved these changes
Aug 14, 2023
|
Needs a |
added 4 commits
August 14, 2023 17:08
This reverts commit 3d039f3. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
This reverts commit 07a2a71. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
This reverts commit badbecc. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
This reverts commit cc92163. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
lindig
force-pushed
the
private/christianlin/CA-379112
branch
from
9f5fda9 to
73cc6aa
Compare
edwintorok
approved these changes
Aug 15, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
…CPU check to the target host (#6175) Rebased the work from 2023 merged in #5111 and #5132, that caused issues and was partially fixed in #5148, but was completely reverted in #5147. I've integrated the fix from #5148 and additionally the fix suggested by @minglumlu in CA-380715 that was not merged at the time due to time constraints. This series passed the tests that were originally failing: sxm-unres (Job ID 4177739), vGPUSXMM60CrossPool (4177750), and also passed the Ring3 BST+BVT (209341). I can run more migration tests if needed - I've heard @Vincent-lau has requested for these to be separated into its own suite instead of being only in Core and Distribution regression tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see some errors in the context of snapshots that we need to investigate.