xenopsd/xc: Print all information in Service_failed exceptions #4807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
This means that now xensource.log will contain the reason that produced these exceptions Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
lindig
approved these changes
Oct 4, 2022
lindig
reviewed
Oct 4, 2022
|
|
||
| let () = | ||
| Printexc.register_printer (function | ||
| | Service_failed (service, reason) -> |
There was a problem hiding this comment.
This installs a printer for an existing exception.
lindig
reviewed
Oct 4, 2022
| | "host", "https_only" -> | ||
| Some "22.26.0-next" | ||
| Some "22.27.0" | ||
| | "host", "last_software_update" -> |
There was a problem hiding this comment.
Do we want this as part of the PR?
There was a problem hiding this comment.
If it's not part of this PR it will need to go in independently because anybody that builds on top of master will get these changes
There was a problem hiding this comment.
Yes, it is good to include these in whatever PR comes after the tag.
robhoes
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that now xensource.log will contain the reason that produced
these exceptions
Reported by @xennifer