CP-40752 Added CLI functionality for pool level setter and getter (https_only) #4806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need to rebase, because this includes a commit for "CP-40751 Added and implemented Pool.set_https_only", which is already in. |
robhoes
reviewed
Oct 4, 2022
ocaml/xapi-cli-server/records.ml
Outdated
| ; make_field ~name:"repository-proxy-username" | ||
| ~get:(fun () -> (x ()).API.pool_repository_proxy_username) | ||
| () | ||
| ; make_field ~name:"https_only" |
There was a problem hiding this comment.
In the CLI, we use - rather than _.
jameshensmancitrix
force-pushed
the
private/jameshen/host_https_only
branch
from
f7b1133 to
cdb505c
Compare
Signed-off-by: jameshensmancitrix <james.hensman@citrix.com>
jameshensmancitrix
force-pushed
the
private/jameshen/host_https_only
branch
from
cdb505c to
6745398
Compare
robhoes
approved these changes
Oct 4, 2022
psafont
reviewed
Oct 4, 2022
psafont
approved these changes
Oct 4, 2022
psafont
reviewed
Oct 4, 2022
Comment on lines
+1436
to
+1440
| |> List.map (fun h -> | ||
| Client.Host.get_https_only ~rpc ~session_id ~self:h | ||
| ) | ||
| |> List.fold_left ( && ) true | ||
| |> string_of_bool |
There was a problem hiding this comment.
The standard library provides a handy function for this: https://v2.ocaml.org/api/List.html#val__for_all
Suggested change
| |> List.map (fun h -> | |
| Client.Host.get_https_only ~rpc ~session_id ~self:h | |
| ) | |
| |> List.fold_left ( && ) true | |
| |> string_of_bool | |
| |> List.for_all (fun h -> | |
| Client.Host.get_https_only ~rpc ~session_id ~self:h | |
| ) | |
| |> string_of_bool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.