Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-53577: Fix 'xe vm-install' of snapshots #45

Merged
1 commit merged into from
Mar 11, 2011
Merged

CA-53577: Fix 'xe vm-install' of snapshots #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
CA-53577: fix base-case of 'if true || x || y' into 'if false || x || y' 
Fixes bug introduced in c/s 99258d9

Signed-off-by: David Scott <dave.scott@eu.citrix.com>
  • Loading branch information
David Scott committed Mar 10, 2011
commit 812c68b05b2e8fe341f7702e3027ad7da384737f
2 changes: 1 addition & 1 deletion ocaml/xapi/cli_operations.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1971,7 +1971,7 @@ let vm_install_real printer rpc session_id template name description params =

let sr_ref =
if Client.VM.get_is_a_snapshot rpc session_id template then
if true
if false
|| (List.mem_assoc "sr-name-label" params
|| List.mem_assoc "sr-uuid" params) then
failwith "Do not use the sr-name-label or sr-uuid argument when installing from a snapshot. By default, it will install each new disk on the same SR as the corresponding snapshot disks."
Expand Down