[CP-18781] Use the correct vif device id in set_MTU or fail #2760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2016 12:51
When updating the MTU of a `VIF` it can happen that the VM `domid` is still out of sync and consequently the computed device id is wrong. We can use the correct device value passing it via `xenopsd` as a field in `VIF.stat`. See also xapi-project/xcp-idl#131 and xapi-project/xenopsd#288 Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
ocaml/xapi/xapi_xenops.ml
Outdated
| let dbg = Context.string_of_task __context in | ||
| let mtu = Net.Interface.get_mtu dbg ~name:device in | ||
| Db.VIF.set_MTU ~__context ~self:vif ~value:(Int64.of_int mtu) | ||
| if Opt.is_none state.device |
Member
There was a problem hiding this comment.
It is more common, and IMO clearer, to use a normal match:
match state.device with
| None -> ...
| Some device -> ...
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
mseri
changed the title
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the MTU of a
VIFit can happen that the VMdomidis still out of sync and consequently the computed device id is wrong.We can use the correct device value passing it via
xenopsdas a field inVIF.stat.See also:
xapi-project/xcp-idl#131
xapi-project/xenopsd#288