[CP-18781] Always se the correct domid value in update_vif
#2758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2016 16:50
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
ocaml/xapi/xapi_xenops.ml
Outdated
| (* in the database is completely updated *) | ||
| let some_domid = Opt.map (fun x -> (snd x).domid) info | ||
| |> Opt.join in | ||
| match some_domid with |
Member
There was a problem hiding this comment.
We are already inside a match on info, where state is the record you need. So you can just match on state.domid here. Or state.device when we switch from domid to device name in the type (see comment on the xcp-idl PR).
Member
There was a problem hiding this comment.
Also, the indentation looks one step too far to the right.
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Contributor
Author
|
I make a new PR with the latest changes, based on the latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the MTU of a VIF it can happen that the VM domid is still out of sync. We can use the correct
domidvalue passing it viaxenopsdas a field inVIF.stat.See also xapi-project/xcp-idl#131 and xapi-project/xenopsd#288
Signed-off-by: Marcello Seri marcello.seri@citrix.com