CA-214015: Don't check for domain zero in is_hvm #2682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her it's HVM." This reverts commit 54933c4. This was only added to placate a test case which had not correctly used the dom0 record for plugging a dummy VBD to dom0. In general we don't want this commit because it breaks VM.import.
Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
|
Yep looks good |
|
/cc @kc284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 54933c4 excluded domain zero from the
is_hvmcheck as a special case.This was only added to placate a test case which had not correctly used
the dom0 record for plugging a dummy VBD to dom0. In general we don't
want this commit because it breaks VM.import because it cannot get the VM record for the incoming VM from the database because, by definition it is not there yet.
This pull request reverts 54933c4 and fixes the offending test-case to get domain zero's VM record properly. Previously it was using
Test_common.make_vmwhich created a HVM record which was then subject to PV driver checks for the VBD allowed-operations.