CP-17469: Treat all known PCI classes as managed #2670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
This means that the VM.attached_PCIs will be updated when the VM is started and shutdown and this will inform the VM.allowed_operations. For example, VMs with PCI-passthrough (using the other-config:pci key) will have the same operation restrictions as a VM using GPU-passthrough (previously the only class of managed PCI device). Presently the operations restricted based on attached PCI devices are: * suspend * checkpoint * pool_migrate * migrate_send Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
|
Nice, looks like that is all you need indeed, assuming we only care about GPUs, network controllers, and storage controllers for the moment. |
|
Thanks for the speedy review @robhoes. I'll add the reviewed label but I'm going to hold off merging until we fix the BVT. Don't want to muddy the water... |
|
Nice! |
|
OK, builds fixed now... In this goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that the VM.attached_PCIs will be updated when the VM is
started and shutdown and this will inform the VM.allowed_operations.
For example, VMs with PCI-passthrough (using the other-config:pci key)
will have the same operation restrictions as a VM using GPU-passthrough
(previously the only class of managed PCI device). Presently the
operations restricted based on attached PCI devices are:
Signed-off-by: Si Beaumont simon.beaumont@citrix.com