Skip to content

Add APIs, CLIs, Unit Tests and functions for VM Schedule Snapshot #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 7, 2016
Merged

Add APIs, CLIs, Unit Tests and functions for VM Schedule Snapshot #2668

merged 9 commits into from
Jun 7, 2016

Conversation

@sharady
Copy link
Contributor

@sharady sharady commented May 31, 2016

No description provided.

sharady added 9 commits May 27, 2016 06:38
@sharady
CP-15502: Add vmss_record for Snapshot Schedule
946329a 
Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
@sharady
CP-15502: Add new fields to vm_record for Snapshot Schedule
53f8d86 
1) snapshot-schedule : VM part of snapshot schedule.
2) is-vmss-snapshot : Snapshot created from VMSS.

Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
@sharady
CP-15502: Update test to handle new fields for vm_record
b56a67e 
Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
@sharady
CP-15502: Add tab completion for VMSS new fields
d9707a8 
Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
@sharady
CP-15502: Add VM Snapshot Schedule CLI commands
5f99dbd 
Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
@sharady
CP-15502: Add APIs for Snapshot Schedule
6450d06 
Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
@sharady
CP-15502: Add VM Scheduled Snapshot functions
3f4f875 
Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
@sharady
CP-16099: Add unit tests for snapshot schedule
055e764 
Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
@sharady
CP-16030: Add license checks for VMSS Calls
48736d3 
Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
@simonjbeaumont
Copy link
Contributor

simonjbeaumont commented May 31, 2016 •
edited
Loading 

06:07:12 File "xapi_xenops.ml", line 669, characters 5-24:
06:07:12 Error: This record expression is expected to have type
06:07:12          Xenops_interface.Vgpu.gvt_g
06:07:12        The field monitor_config_file does not belong to type Xenops_interface.Vgpu.gvt_g

I think this is because of the new work that @johnelse has done on GVT-g that hasn't hit the yum repo yet for xcp-idl. I've restarted the travis job as it might be in now.

@simonjbeaumont
Copy link
Contributor

@xen-git: retest this please.

@simonjbeaumont
Copy link
Contributor

Confirmed this builds locally using xenserver-build-env using -b trunk-ring3.

@simonjbeaumont
Copy link
Contributor

simonjbeaumont commented May 31, 2016 •
edited
Loading

Wait, this is a pull-request for feature-vmss which is synced with trunk-vmss internally. This will fail to build if merged and it needs to be rebased in light of recent changes in xcp-idl. Maybe you have the changes in this tree but the destination branch (trunk-vmss) needs to be updated.

I've just tested this using:

xenserver-build-env$ ./run.py -b trunk-vmss -p xapi ...
sh-4.2$ sudo su
[root@549de09885dc builder]# cd /external/code/xen-api
[root@549de09885dc xen-api]# configure && make
...
File "xapi_xenops.ml", line 669, characters 5-24:                                                                    
Error: This record expression is expected to have type
         Xenops_interface.Vgpu.gvt_g
       The field monitor_config_file does not belong to type Xenops_interface.Vgpu.gvt_g

@sharady
Copy link
Contributor Author

sharady commented May 31, 2016

I have done a b2b from trunk to trunk-vmss which should have all latest changes. Will build this PR once more.

@sharady
Copy link
Contributor Author

sharady commented Jun 2, 2016

@xen-git: retest this please.

@simonjbeaumont
Copy link
Contributor

All CI passing now, removing the needs-updating flag. These PRs still need some level of review though.

lindig
lindig reviewed Jun 6, 2016
View reviewed changes
ocaml/test/test_map_check.ml
List.map (fun (a, b) ->
let inner_string = List.map (fun (c, d) -> let e, f = d in
c ^ "," ^ (string_of_ty e) ^ f ) b |> String.concat ";" in
"[" ^ a ^ "," ^ "[" ^ inner_string ^ "]]"
Copy link
Contributor

@lindig lindig Jun 6, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would using Printf.sprintf be simpler? I also feel that the pattern match in string_of_ty could lead to hard-to-find bugs if you don't expect other types than String. Maybe using an exception for _ would be safer.

@simonjbeaumont
Copy link
Contributor

These tests can only leave us in a better situation than we're currently in.

@simonjbeaumont simonjbeaumont merged commit b93561b into xapi-project:trunk-vmss Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharady @simonjbeaumont @lindig