CA-201093: mail-alarm: Add formatter for log partition usage alerts #2602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked on the fix for CA-201311 since that solves the Python 0 = false problem in all the formatters. Once @jonludlam pushes his fix for that, I'll rebase this patch so that I don't fix it in a completely different way/style for this one formatter. |
|
Needs rebasing on #2603 |
Before this patch, emails would come in unformatted like the following:
From: noreply@dt04
To: simon.beaumont@citrix.com
Date: Tue, 1 Mar 2016 17:34:00 +0000
Subject: [dt04] XenServer Message: VM 88eea7dc-6b81-4a1e-a43d-86b3eb097fd5
ALARM
Field Value
----- -----
Name: ALARM
Priority: 3
Class: VM
Object UUID: 88eea7dc-6b81-4a1e-a43d-86b3eb097fd5
Timestamp: 20160301T17:33:53Z
Message UUID: 4116332a-995e-57d1-a318-c9c06a08c918
Pool name: dt04
Body:
Parameter=log_fs_usage
Value=0.040000
Alarm trigger value=0.0
Alarm trigger period=0
Now they come in formatted like this:
From: noreply@dt04
To: simon.beaumont@citrix.com
Date: Tue, 1 Mar 2016 17:39:56 +0000
Subject: [dt04] XenServer Alarm: Log partition nearly full on "Control domain
on host: dt04"
The log partition usage on "Control domain on host: dt04" is at 4.0%.
This alarm is set to be triggered when log partition usage is more than 0.0%.
Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
simonjbeaumont
force-pushed
the
ca-201093
branch
from
7444005 to
29ffdbc
Compare
|
Looks good! It's going in. |
johnelse
added a commit
that referenced
this pull request
Mar 3, 2016
CA-201093: mail-alarm: Add formatter for log partition usage alerts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, emails would come in unformatted like the following:
Now they come in formatted like this:
Signed-off-by: Si Beaumont simon.beaumont@citrix.com