[RFC]: Add a 'floppy' VBD type (take #2) #2068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Scott <dave.scott@eu.citrix.com>
Restricts the permitted floppy userdevice values to "fda" and "fdb". Allows new floppy VBDs to have userdevice set to "autodetect".
|
Can one of the admins verify this patch for testing? |
|
@xen-git test this please |
djs55
added a commit
that referenced
this pull request
Jan 5, 2015
[RFC]: Add a 'floppy' VBD type (take #2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original pull request: #2057
This fixes two bugs. Floppy VBDs can now be successfully attached and used in HVM guests.
The first commit 6c391c5 fixes userdevice assignment issues, so that floppies are properly assigned an "fd?" rather than "xvd?". qemu requires this, in addition to the drive being on the "floppy" bus.
Despite
Device_number.to_disk_numbernot being unique (see xapi-project/xcp-idl#47), it is still used in several places around the code. We need to check these to make sure they don't interfere with floppy support. The second commit bde0bb6 is an example of fixing this, where xen-api would previously get confused between "fda" and "xvda" on reboot of a guest, and subsequently overwrite the "xvda" VBD metadata with the "fda".Requires: