Skip to content

[RFC]: Add a 'floppy' VBD type #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[RFC]: Add a 'floppy' VBD type #2057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ocaml/idl/datamodel.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5738,7 +5738,8 @@ let vbd_mode = Enum ("vbd_mode", [ "RO", "only read-only access will be allowed"

let vbd_type = Enum ("vbd_type",
[ "CD", "VBD will appear to guest as CD";
"Disk", "VBD will appear to guest as disk" ])
"Disk", "VBD will appear to guest as disk";
"Floppy", "VBD will appear as a floppy"])

let vbd_operations =
Enum ("vbd_operations",
Expand Down
5 changes: 4 additions & 1 deletion ocaml/xapi/xapi_xenops.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,10 @@ module MD = struct
position = Some device_number;
mode = if vbd.API.vBD_mode = `RO then ReadOnly else ReadWrite;
backend = disk_of_vdi ~__context ~self:vbd.API.vBD_VDI;
ty = if vbd.API.vBD_type = `Disk then Disk else CDROM;
ty = (match vbd.API.vBD_type with
| `Disk -> Disk
| `CD -> CDROM
| `Floppy -> Floppy);
unpluggable = vbd.API.vBD_unpluggable;
extra_backend_keys = backend_kind_keys;
extra_private_keys = [];
Expand Down