Remove use of the camlp4 lwt syntax #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
lindig
reviewed
Feb 8, 2017
| proxy fd (Lwt_unix.of_unix_file_descr proxy_socket) in | ||
| let t_unix = | ||
| lwt fd, peer = Lwt_unix.accept s_unix in | ||
| Lwt_unix.accept s_unix >>= fun (fd, peer) -> |
There was a problem hiding this comment.
I think the use of a pair for (fd, peer) is faithful to the original but not necessary. The function could simply take to parameters: fun fd peer ->.
There was a problem hiding this comment.
It seems that Lwt_unix.accept returns a pair, so sadly we cannot change that if I'm not mistaken:
val accept : file_descr -> (file_descr * sockaddr) Lwt.t| let buffer = String.make (String.length token) '\000' in | ||
| let io_vector = Lwt_unix.io_vector ~buffer ~offset:0 ~length:(String.length buffer) in | ||
| lwt n, fds = Lwt_unix.recv_msg ~socket:fd ~io_vectors:[io_vector] in | ||
| Lwt_unix.recv_msg ~socket:fd ~io_vectors:[io_vector] >>= fun (n, fds) -> |
There was a problem hiding this comment.
Same as above==: fun n fds ->
| *) | ||
|
|
||
| open Sexplib.Std | ||
| include Xenops_types.TopLevel |
There was a problem hiding this comment.
I'm not a big fan of include because it introduces a lot of names unqualified into the current scope. I understand why it is here, though.
lindig
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jon Ludlam jonathan.ludlam@citrix.com