Skip to content

Conversation

@johnelse
Copy link
Collaborator

No description provided.

Signed-off-by: John Else <john.else@citrix.com>
@robhoes
Copy link
Member

robhoes commented May 24, 2016

Don't we need a default somewhere for the upgrade case? An a line containing Rpc.struct_extend somewhere?

@johnelse
Copy link
Collaborator Author

johnelse commented May 24, 2016

In this case I don't think so - missing keys in dicts get translated into None automatically by rpclib, if the field is an option type.

@robhoes
Copy link
Member

robhoes commented May 24, 2016

Ah, good. In that case: :shipit:

@johnelse johnelse merged commit a88c9b9 into xapi-project:master May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants