Remove select and apply make format #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snwoods
force-pushed
the
private/stevenwo/CP-32622
branch
from
af658c3 to
3069337
Compare
|
Please add polly dependency in the uniext opam metadata, it would be great to have unit tests for unixext as well |
|
For the unit-tests you cna see how the list module is tested with a test binary: https://github.com/xapi-project/stdext/blob/master/lib/xapi-stdext-std/listext_test.ml |
snwoods
force-pushed
the
private/stevenwo/CP-32622
branch
from
3069337 to
dbccd6d
Compare
|
Please separate the reformatting and the removal of select into different commits |
Signed-off-by: Steven Woods <steven.woods@citrix.com>
snwoods
force-pushed
the
private/stevenwo/CP-32622
branch
from
dbccd6d to
b098648
Compare
Signed-off-by: Steven Woods <steven.woods@citrix.com>
Signed-off-by: Steven Woods <steven.woods@citrix.com>
snwoods
force-pushed
the
private/stevenwo/CP-32622
branch
from
b098648 to
d2019b5
Compare
lindig
approved these changes
Feb 15, 2023
| ignore | ||
| @@ Polly.wait epoll 4 (-1) (fun _ file_desc event -> | ||
| (* Do the writing before the reading *) | ||
| if event = Polly.Events.out then |
There was a problem hiding this comment.
This could be simplified to if event = Polly.Events.out && a = file_desc then ... ;
This was referenced Nov 28, 2023
Merged
|
Moved to xapi-project/xen-api#5402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.