Warning fixes and other cleanups #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| body, _ := ioutil.ReadFile(filename) | ||
| w.Write([]byte(body)) | ||
| } | ||
|
|
||
| func TestNewClient(t *testing.T) { |
There was a problem hiding this comment.
Please do not delete these unused test functions. We need to start adding some tests and these helper functions will be needed when we do... So I would like to keep these in.
|
Hi @mvdan, looks good! Thanks! I would like to keep the (currently) unused test helper functions, so if you can revert deleting them I'll merge the rest of this PR 👍 |
|
@mvdan I still would like to pull this one in, but you would first have to rebase it and revert the part where you delete the unused test functions. If you can do that, that would be great and I'll merge this PR right after... Thanks! |
|
I just went on holidays right after opening this, so give me a couple of days :) |
|
Sure, no rush! Thx 😀 |
It has methods to write strings and bytes already, which is much easier and also faster than going through a regular write of []byte.
|
@svanharmelen done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.