Skip to content
This repository has been archived by the owner on Jul 26, 2021. It is now read-only.

Allow overriding the default http client used in CS API requests #115

Closed
wants to merge 1 commit into from

Conversation

cezarsa
Copy link
Contributor

@cezarsa cezarsa commented Jun 4, 2019

This commit adds a method to simply replace the entire http client used for requests against the CS API. This could be useful for tweaking timeout values or even using a custom transport to log requests to the CS API.

This commit adds a method to simply replace the entire http client used
for requests against the CS API. This could be useful for tweaking
timeout values or even using a custom transport to log requests to the
CS API.
@svanharmelen
Copy link
Member

@cezarsa I think adding a more generic approach is maybe a better solution. Can you check/test if #116 solves your challenge?

@cezarsa
Copy link
Contributor Author

cezarsa commented Jun 5, 2019

Thanks @svanharmelen. I wasn't sure about what you would prefer as pattern for customizing the client so I went with the simpler solution. However, I think your solution is better and will make it easier adding further options in the future.
Closing in favor of #116.

@cezarsa cezarsa closed this Jun 5, 2019
@svanharmelen
Copy link
Member

Did you have a change to double check the changes in #116?

@cezarsa
Copy link
Contributor Author

cezarsa commented Jun 6, 2019

No need for changes on #116, it works perfectly as is. I've just created a PR updating my code to the branch used in #116 and it works really well: https://github.com/tsuru/custom-cloudstack-ccm/pull/18/files#diff-e6bf6fd6123b13e2f45eaf8b1133c2d5R178

@svanharmelen
Copy link
Member

Nice 👍🏻 Thanks for testing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants