[mmp/mtouch] Don't link with frameworks not available in the current SDK. Fixes #59636. #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SDK. Fixes #59636. We already have this logic for frameworks we detect according to the namespace of the used types, but not for frameworks we detect from P/Invokes. Fix this by using the same framework exclusion logic for frameworks detected from P/Invokes: don't link with frameworks not available in the current SDK. https://bugzilla.xamarin.com/show_bug.cgi?id=59636
|
Build success |
spouliot
approved these changes
Sep 26, 2017
dalexsoto
approved these changes
Sep 26, 2017
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Sep 27, 2017
…SDK. Fixes #59636. (xamarin#2777) We already have this logic for frameworks we detect according to the namespace of the used types, but not for frameworks we detect from P/Invokes. Fix this by using the same framework exclusion logic for frameworks detected from P/Invokes: don't link with frameworks not available in the current SDK. https://bugzilla.xamarin.com/show_bug.cgi?id=59636
rolfbjarne
added a commit
that referenced
this pull request
Sep 27, 2017
…SDK. Fixes #59636. (#2777) (#2784) We already have this logic for frameworks we detect according to the namespace of the used types, but not for frameworks we detect from P/Invokes. Fix this by using the same framework exclusion logic for frameworks detected from P/Invokes: don't link with frameworks not available in the current SDK. https://bugzilla.xamarin.com/show_bug.cgi?id=59636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have this logic for frameworks we detect according to the namespace
of the used types, but not for frameworks we detect from P/Invokes.
Fix this by using the same framework exclusion logic for frameworks detected
from P/Invokes: don't link with frameworks not available in the current SDK.
https://bugzilla.xamarin.com/show_bug.cgi?id=59636