[Rgen] Provide all the wiring to allow to emit code. #21460

mandel-macaque · 2024-10-16T17:24:27Z

Add the following:

Code needed to register the changes in the compiler pipeline.
Code that will add the using statements for the generated code that match those in the binding file.
Code that allows to write tabbed code in a way we do not have to keep track of indentation.

We have the first unit test that verifies code generation by checking the using statements.

Add the following: 1. Code needed to register the changes in the compiler pipeline. 2. Code that will add the using statements for the generated code that match those in the binding file. 3. Code that allows to write tabbed code in a way we do not have to keep track of indentation. We have the first unit test that verifies code generation by checking the using statements.

mandel-macaque · 2024-10-16T17:27:50Z

src/rgen/Microsoft.Macios.Generator/BindingSourceGeneratorGenerator.cs

+			.OfType<UsingDirectiveSyntax> ()
+			.Select (d => d.Name.ToString ()).ToArray ();
+		var usingDirectivesToKeep = new HashSet<string> (usingDirectives) {
+			// add the using statements that we know we need and print them to the sb


@rolfbjarne do we have a list of the namespaces that we ALWAYS need for the binding code?

I think I can construct a test case that doesn't need any namespaces at all.

That said, Foundation and ObjCRuntime will pretty much always be required.

github-actions · 2024-10-16T17:28:15Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions · 2024-10-16T21:31:28Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

src/rgen/Microsoft.Macios.Generator/TabbedStringBuilder.cs

rolfbjarne · 2024-10-18T15:38:55Z

src/rgen/Microsoft.Macios.Generator/Context/RootBindingContext.cs

+	}
+
+	// TODO: clean code coming from the old generator
+	public bool TryComputeLibraryName (string attributeLibraryName, string typeNamespace,


Then just move the method from this PR to that PR - it's really hard to figure out whether this is properly tested when the tests aren't here.

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

github-actions · 2024-10-18T17:48:57Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2024-10-18T20:47:33Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 101 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 3 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: dbbdf510ede7dd9527cad254fd62a7c53e092cb2 [PR build]

rolfbjarne · 2024-10-21T13:58:52Z

src/rgen/Microsoft.Macios.Generator/BindingSourceGeneratorGenerator.cs

+				// we don't have a emitter for this type, so we can't generate the code, add a diagnostic letting the
+				// user we do not support what he is trying to do
+				continue;


The comment says something about adding a diagnostic, but it doesn't look like the code does?

src/rgen/Microsoft.Macios.Generator/TabbedStringBuilder.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

vs-mobiletools-engineering-service2 · 2024-10-21T18:29:40Z

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Build macOS tests'

Pipeline on Agent
Hash: 13a37913a1e2d0f0e8b0bf9f25cf05a7910ec192 [PR build]

…gnostic.

github-actions · 2024-10-21T21:52:37Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2024-10-21T23:12:30Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 2da0eb6674f06e8cc2eda41c72d5629989571e37 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-21T23:16:14Z

✅ API diff for current PR / commit

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2da0eb6674f06e8cc2eda41c72d5629989571e37 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-21T23:17:52Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 2da0eb6674f06e8cc2eda41c72d5629989571e37 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-21T23:22:48Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 2da0eb6674f06e8cc2eda41c72d5629989571e37 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-21T23:24:08Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 2da0eb6674f06e8cc2eda41c72d5629989571e37 [PR build]

mandel-macaque commented Oct 16, 2024

View reviewed changes

Auto-format source code

1ac8974

This comment has been minimized.

Sign in to view

Fix makefile.

89aef62

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/mandel/rgen-wiring

f6f8811

This comment has been minimized.

Sign in to view

mandel-macaque and others added 5 commits October 16, 2024 17:14

Merge TryValidate and Emit since it makes the API cleaner.

c8ddb0a

enuable nullable first so that emitters can add extra namespaces.

56c7ed2

Fix the sample projects.

ae1b14a

Fix analyzer tests.

d4fb40e

Auto-format source code

ad83462

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Oct 18, 2024

View reviewed changes

mandel-macaque and others added 4 commits October 18, 2024 13:41

Apply suggestions from code review

a208851

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Fix tabbeb string build that broke after applying comments from PR.

c59f13c

Remove method that will be re-added in the following rgen pr.

1662432

Auto-format source code

dbbdf51

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Oct 21, 2024

View reviewed changes

Apply suggestions from code review

13a3791

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

This comment has been minimized.

Sign in to view

mandel-macaque and others added 2 commits October 21, 2024 17:48

Rever the interpolation change, we will do that in a diff pr. Add dia…

d559c68

…gnostic.

Auto-format source code

2da0eb6

[Rgen] Provide all the wiring to allow to emit code. #21460

Are you sure you want to change the base?

[Rgen] Provide all the wiring to allow to emit code. #21460

Conversation

mandel-macaque commented Oct 16, 2024

mandel-macaque Oct 16, 2024

Choose a reason for hiding this comment

rolfbjarne Oct 17, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 16, 2024

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 16, 2024

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Oct 18, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 18, 2024

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 18, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

rolfbjarne Oct 21, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 21, 2024

🔥 [CI Build] Build failed 🔥

github-actions bot commented Oct 21, 2024

⚠️ Your code has been reformatted. ⚠️

vs-mobiletools-engineering-service2 commented Oct 21, 2024

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Oct 21, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 21, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Oct 21, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Oct 21, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻